-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OAuthenticator reply parsing. #5603
Conversation
Provide QByteArray instead of QIODevice to QJson parser. Bug link: flavio/qjson#52
Probably will fix #5457 |
If this really fixes things, then I'd like to know why because we have this pattern everywhere. |
This pattern is correct, but there is a regression in libqjson, which was introduced between 0.8.1 and 0.9.0 releases (flavio/qjson@774c778 - break commit, if someone is interested). |
I've updated all problem places in code. It resolves issues with loggin into Google Drive and Dropbox, for example. |
We should rely on the upstream fix I think and perhaps check for QJson > 0.9.0 at compile time. |
@hatstand But clementine use shared version of qjson, so compile time check wouldn't solve the problem. |
I realise it's not perfect but it's best if we can avoid adding more things to 3rdparty. Perhaps we can add a wrapper function for now that we use everywhere. The best thing to do would be to harass distros into updating their qjson for the bugfix. |
This bug in QJson also breaks fetching tags from Musicbrainz. |
Nevermind, Clementine is still using Qt4. Well, I can help if somebody decides how to solve this (globally). |
Provide QByteArray instead of QIODevice to QJson parser.
Bug link: flavio/qjson#52